Add over provision factor #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
over-provision-factor
branch
from
0a16f92 to
6cc3906
Compare
Adds a new overprovision parameter that calculates the capacity of a given storage pool based on the existing reserved space. While we would like to use LINSTOR directly for that, it does not seem to be implemented: the "query-size-info" call seems to return inconsistent results. The advantage of the new parameter is that people can opt-in to this new calculation by setting the parameter. Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
over-provision-factor
branch
from
6cc3906 to
dca9d70
Compare
rck
reviewed
Nov 9, 2023
With the addition of the overprovision parameter, we potentially start a lot of requests for the resource view. So we add a cache for this call, in the same way we have a cache for the node state and storage pools. Signed-off-by: Moritz Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
over-provision-factor
branch
from
dca9d70 to
add38c4
Compare
Yes and no. There are multiple issue along the way:
In general, I would like to see this moved to LINSTOR, but I fear it will take a LINSTOR v2 to get around to it. Perhaps then we also have an AutoPlacer that supports all the requirements one can already specify in LINSTOR CSI :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new overprovision parameter that calculates the capacity of a given
storage pool based on the existing reserved space.
While we would like to use LINSTOR directly for that, it does not seem to
be implemented: the "query-size-info" call seems to return inconsistent
results.
The advantage of the new parameter is that people can opt-in to this new
calculation by setting the parameter.
This also adds a cache for the call to
Resources.GetResourceView(), as the CapacityBytes() is one of the "hottest" code paths, and we don't actually need to monitor the usage that closely.