support deletion of snapshots after restore from backup #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanzenBug
force-pushed
the
delete-snapshots-after-restore-if-backup
branch
from
6475bac to
845d65c
Compare
rck
reviewed
Oct 6, 2023
When a user requests a restore from an off-site backup, they might want the local snapshot to be deleted after the restore. We already have this option when creating the snapshot by using a special parameter on the snapshot class. However, we do not have that information available directly. To support this, we need to lookup the snapshot content and snapshot class ourselfes, then parse the parameters. This is all optional, as LINSTOR CSI still needs to work outside kubernetes, or inside Kubernetes with incomplete information. Signed-off-by: Moritz "WanzenBug" Wanzenböck <[email protected]>
WanzenBug
force-pushed
the
delete-snapshots-after-restore-if-backup
branch
from
845d65c to
40ea244
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user requests a restore from an off-site backup, they might want the local snapshot to be deleted after the restore.
We already have this option when creating the snapshot by using a special parameter on the snapshot class. However, we do not have that information available directly.
To support this, we need to lookup the snapshot content and snapshot class ourselfes, then parse the parameters. This is all optional, as LINSTOR CSI still needs to work outside kubernetes, or inside Kubernetes with incomplete information.