Skip to content

Commit

Permalink
update golinstor to fix caching issue
Browse files Browse the repository at this point in the history
The golinstor caching implementation did not filter by properties, which is
used by the NodesForTopology() call to filter the nodes based on properties.

This meant that in some scenarios, LINSTOR CSI would place volumes on
unexpected nodes, as it got the full list of nodes instead of one filtered
to just some property.

Signed-off-by: Moritz Wanzenböck <[email protected]>
  • Loading branch information
WanzenBug authored and rck committed Jun 27, 2024
1 parent 6baa85b commit 97757d2
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Fixed node filtering when initial placement was not possible. This now takes the remoteAccessPolicy into account like
intended.

## [1.6.2] - 2024-06-19

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ go 1.22.0
toolchain go1.22.2

require (
github.com/LINBIT/golinstor v0.52.1
github.com/LINBIT/golinstor v0.52.2
github.com/container-storage-interface/spec v1.9.0
github.com/haySwim/data v0.2.0
github.com/kubernetes-csi/csi-test/v5 v5.2.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
github.com/LINBIT/golinstor v0.52.1 h1:TBLv3E9Lr7cEDQvorRivZhtZS5xP1oUUOxoAGBwJoAg=
github.com/LINBIT/golinstor v0.52.1/go.mod h1:D811Eyjhoy6t1Tl36HTW4by0s6O5g0cVgV/t58oN+0g=
github.com/LINBIT/golinstor v0.52.2 h1:O2+NRWUfn0WdgslVRywF1it2+qS1Zkak/RuuZZMY0vs=
github.com/LINBIT/golinstor v0.52.2/go.mod h1:aPtOD/STz0JO0u7xrOVH3ZdzpDHwXcHzjKzczOReXu8=
github.com/container-storage-interface/spec v1.9.0 h1:zKtX4STsq31Knz3gciCYCi1SXtO2HJDecIjDVboYavY=
github.com/container-storage-interface/spec v1.9.0/go.mod h1:ZfDu+3ZRyeVqxZM0Ds19MVLkN2d1XJ5MAfi1L3VjlT0=
github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
Expand Down

0 comments on commit 97757d2

Please sign in to comment.