do not attach volume with no replicas

Signed-off-by: Moritz Wanzenböck <[email protected]>
piraeusdatastore · Jan 25, 2024 · 9541e91 · 9541e91
1 parent 271af99
commit 9541e91
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
-- Do not try to create diskless resource if there is no compatible diskless layer (DRBD or NVMe) available
+- Do not try to create diskless resource if there is no compatible diskless layer (DRBD or NVMe) available.
+- Do not allow attaching a volume that has no existing replica.
 
 ## [1.3.0] - 2023-11-15
 

diff --git a/pkg/client/linstor.go b/pkg/client/linstor.go
@@ -469,10 +469,14 @@ func (s *Linstor) Attach(ctx context.Context, volId, node string, rwxBlock bool)
 	}).Info("attaching volume")
 
 	ress, err := s.client.Resources.GetAll(ctx, volId)
-	if nil404(err) != nil {
+	if err != nil {
 		return err
 	}
 
+	if len(ress) == 0 {
+		return fmt.Errorf("failed to attach resource with no deployed replica")
+	}
+
 	var existingRes *lapi.Resource
 
 	disklessFlag := ""