improve object access detection (#51)

pipopotamasu · Feb 23, 2024 · 0fce0df · 0fce0df
1 parent a558335
commit 0fce0df
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/rules/no-implicit-any/member-expression/index.spec.ts b/rules/no-implicit-any/member-expression/index.spec.ts
@@ -133,5 +133,20 @@ ruleTester.run('member-expression', rule, {
         `,
       errors: [{ messageId: 'missingAnyType' }],
     },
+    {
+      code: `
+        function fn (arg: { foo: string }) {
+          const keyName: string = 'bar';
+          arg[keyName];
+        }
+        `,
+      output: `
+        function fn (arg: { foo: string }) {
+          const keyName: string = 'bar';
+          (arg as any)[keyName];
+        }
+        `,
+      errors: [{ messageId: 'missingAnyType' }],
+    },
   ],
 });
diff --git a/rules/no-implicit-any/member-expression/index.ts b/rules/no-implicit-any/member-expression/index.ts
@@ -21,7 +21,7 @@ export const lintMemberExpression = (
   const nodeType = parserServices.getTypeAtLocation(node);
   const objType = parserServices.getTypeAtLocation(node.object);
 
-  if (nodeType.flags === ts.TypeFlags.Any && objType.symbol?.escapedName === '__object') {
+  if (nodeType.flags === ts.TypeFlags.Any && objType.symbol?.escapedName !== 'Array') {
     context.report({
       node,
       messageId: 'missingAnyType',