-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic support for nix flakes #21
Conversation
Signed-off-by: Isitha Subasinghe <[email protected]>
I'm running into an error with
I think it might be having a hard time installing things on my docker-desktop cluster |
On our call yesterday @rohankmr414 had a question about adding the dependency files. Rohan, could you ask it here? |
I should have probably mentioned this before, but this does assume kubernetes related stuff has been setup. |
@isubasinghe and I hopped on a call today and were able to get my issue sorted. All I had to do was restart the terminal after installing nix rather than just opening up a new tab on iterm 🤷♂️ |
Signed-off-by: Isitha Subasinghe <[email protected]>
Signed-off-by: Isitha Subasinghe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
I had to delete my .devenv
folder after pulling the new commits, but after deleting and refreshing, it worked great
This adds a reproducible build environment for Argo Workflows. Argo Workflows can now be run in a few simple steps documented in the README.md.
Why are there some go files changed here?
This was the outcome of running gofmt on the sources, sources can be reformatted by running "nix fmt".
Currently this only supports formatting golang and nix files but can be extended to anything supported via clang-format, prettier and more. See this for more info: https://numtide.github.io/treefmt/formatters/
The files.go stub was added, this is a bit more deterministic than copying at build time. This will also make caching easier.