-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade aws-sdk-go-v2 versions #5196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🚀
0b5054b
to
72bc76e
Compare
@tom-256 please sign the commit follow failed CI instructions 👀 |
72bc76e
to
5e3ac78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tom-256
Would you fix https://github.com/pipe-cd/pipecd/blob/master/pkg/app/piped/platformprovider/ecs/diff_test.go#L105 as below?
from:
@@ -17,7 +17,7 @@
to:
@@ -18,7 +18,7 @@
That's because the test failed
since the new field RestartPolicy
is added and the row number is slided.
Signed-off-by: tom-256 <[email protected]>
Signed-off-by: tom-256 <[email protected]>
3629ff5
to
50396cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you 👍
Thank you so much, |
It turned out that we need to upgrade all Without that, API calls return To fix it, would you follow the steps below? 1. upgrade all
|
if rule.IsDefault { |
should be:
if *rule.IsDefault {
This is due to a breaking change aws/aws-sdk-go-v2#2333.
I'll continue on #5241 |
What this PR does / why we need it:
For enable restart policy in ECS task definitions.
Which issue(s) this PR fixes:
Fixes #5144
Does this PR introduce a user-facing change?:
I have confirmed that the ECS restart policy is applied correctly with the following YAML configuration.
The resulting ECS task definition JSON has been registered as follows: