Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brand type #67

Merged
merged 8 commits into from
Feb 24, 2019
Merged

Add Brand type #67

merged 8 commits into from
Feb 24, 2019

Conversation

airtoxin
Copy link
Contributor

Fix #66

Copy link
Owner

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you please check and apply my review comments? Thanks!

README.md Outdated
@@ -832,6 +833,29 @@ function makeStore(storeClass: Class<Store>): Store {

[⇧ back to top](#flows-utility-types)

### `Brand<T, U>`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be located in Mapped Types

* Brand
* @desc Define nominal type of U based on type of T.
*/
export type Brand<T, U> = T & { __brand: U };
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move to Mapped Types

/**
* Brand
* @desc Define nominal type of U based on type of T.
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @example as here: #68

@airtoxin
Copy link
Contributor Author

@piotrwitek Thank you reviewing! I fixed them. Please re-review 👓

/**
* Brand
* @desc Define nominal type of U based on type of T.
* @example
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looking great.

Copy link
Owner

@piotrwitek piotrwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@piotrwitek piotrwitek merged commit e119f23 into piotrwitek:master Feb 24, 2019
@piotrwitek
Copy link
Owner

Thanks for your contribution @airtoxin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants