Fix cursor hiding in threaded run #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 15, 2023
orgads
force-pushed
the
improve-hiding
branch
2 times, most recently
from
a02199f to
2aa1e62
Compare
piotrmurach
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Hi Orgad 👋
Nice spot with the issue! Thank you for submitting this PR. There are a few things to resolve before this can be considered for merging. We need an additional test in the auto_spin_spec.rb on top of what's already there that specifically raises inside the thread.
orgads
force-pushed
the
improve-hiding
branch
from
2aa1e62 to
550e197
Compare
houndci-bot
reviewed
Sep 18, 2023
orgads
force-pushed
the
improve-hiding
branch
3 times, most recently
from
a5fd890 to
7aeda4d
Compare
houndci-bot
reviewed
Sep 20, 2023
lib/tty/spinner.rb
Outdated
| spin | ||
| sleep(sleep_time) | ||
| end | ||
| rescue |
There was a problem hiding this comment.
Style/RescueStandardError: Avoid rescuing without specifying an error class.
auto_spin ensure was called right after starting to spin, so the cursor was never actually hidden. Fix by calling the initial spin in the thread, and wrap the thread with rescue that shows the cursor at the end.
orgads
force-pushed
the
improve-hiding
branch
from
7aeda4d to
aaa5ff6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Fix cursor hiding in threaded run.
Why are we doing this?
auto_spin ensure was called right after starting to spin, so the cursor was never actually hidden.
Benefits
See above.
Drawbacks
Requirements
masterbranch?