-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove SampleBuilder from rtp-to-webrtc
SampleBuilder isn't able to properly handle H264. We have multiple issues and until resolved we shouldn't suggest it. Relates to #1652
- Loading branch information
Showing
2 changed files
with
9 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,3 +51,9 @@ Copy the text that `rtp-to-webrtc` just emitted and copy into second text area | |
A video should start playing in your browser above the input boxes. | ||
|
||
Congrats, you have used Pion WebRTC! Now start building something cool | ||
|
||
## Dealing with broken/lossy inputs | ||
Pion WebRTC also provides a [SampleBuilder](https://pkg.go.dev/github.com/pion/webrtc/[email protected]/pkg/media/samplebuilder). This consumes RTP packets and returns samples. | ||
It can be used to re-order and delay for lossy streams. You can see its usage in this example in [e4da70](https://github.com/pion/webrtc/commit/e4da709754639871266ca5e2cc2f945178caeb12). | ||
|
||
Currently it isn't working with H264, but is useful for VP8 and Opus. See [#1652](https://github.com/pion/webrtc/issues/1652) for the status of fixing for H264. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters