Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vnet: NewNet() should return an error #34

Closed
enobufs opened this issue Aug 22, 2019 · 0 comments · Fixed by #204
Closed

vnet: NewNet() should return an error #34

enobufs opened this issue Aug 22, 2019 · 0 comments · Fixed by #204
Milestone
V1

Comments

@enobufs
Copy link
Member

enobufs commented Aug 22, 2019 •
edited
Loading

There may be a case where a configuration error is detected by NewNew(), but it currently does not return an error. (this was found during the review for #33)
@enobufs enobufs mentioned this issue Aug 22, 2019
Merged
stv0g added a commit to stv0g/pion-transport that referenced this issue Sep 1, 2022
@stv0g
Add a new interface 'net.Net' which is now implemented by 'net.StdNet…
29009bf 
…' and 'vnet.Net'

This PR closes pion#34 and clearly separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change allows users to provide their own
'net.Net' implementation for reasons like the one described in pion#34.
@stv0g stv0g mentioned this issue Sep 1, 2022
Merged
stv0g added a commit to stv0g/pion-transport that referenced this issue Sep 10, 2022
@stv0g
Add a new interface 'net.Net'
d0cb708 
With initial implementations by 'net.StdNet' and 'vnet.Net'.
This PR closes pion#34 and clearly separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change allows users to provide their own
'net.Net' implementation for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Oct 9, 2022
@stv0g
Add a new interface 'net.Net'
8d4fe93 
With initial implementations by 'net.StdNet' and 'vnet.Net'.
This PR closes pion#34 and clearly separates the virtual network
'vnet.Net' from the code which is using in production.
Furthermore this change allows users to provide their
own 'net.Net' implementation for reasons like
the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Oct 9, 2022
@stv0g
Add a new interface 'net.Net'
32287c0 
With initial implementations by 'net.StdNet' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Oct 9, 2022
@stv0g
Add a new interface 'net.Net'
193cdec 
With initial implementations by 'net.StdNet' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
@enobufs enobufs mentioned this issue Oct 16, 2022
Closed
@enobufs enobufs added this to the V2 milestone Oct 29, 2022
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 13, 2022
@stv0g
Add a new interface 'net.Net'
b6947e9 
With initial implementations by 'net.StdNet' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 15, 2022
@stv0g
Add a new interface 'transport.Net'
df57668 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 15, 2022
@stv0g
Add a new interface 'transport.Net'
2f73fd3 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 15, 2022
@stv0g
Add a new interface 'transport.Net'
36b8e26 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 15, 2022
@stv0g
Add a new interface 'transport.Net'
03763c9 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 16, 2022
@stv0g
Add a new interface 'transport.Net'
c4ccd46 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit to stv0g/pion-transport that referenced this issue Nov 19, 2022
@stv0g
Add a new interface 'transport.Net'
35de69e 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes pion#34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in pion#34.
stv0g added a commit that referenced this issue Nov 19, 2022
@stv0g
Add a new interface 'transport.Net'
acb7d0c 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes #34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in #34.
Sean-Der pushed a commit that referenced this issue Nov 30, 2022
@stv0g @Sean-Der
Add a new interface 'transport.Net'
479a1c1 
With initial implementations by 'stdnet.Net' and
'vnet.Net'. This PR closes #34 and clearly
separates the virtual network 'vnet.Net' from the code
which is using in production. Furthermore this change
allows users to provide their own 'net.Net' implementation
for reasons like the one described in #34.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V1
Development

Successfully merging a pull request may close this issue.

Add a new interface transport.Net stv0g/pion-transport
1 participant
@enobufs