Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to show that I am working on the Extended Reports.
I am going to work on the tests in extended_reports_test.go, then complete the
unmarshal()
andmarshal()
functions in extended_reports.go.I think the embedded struct idea with pointer struct fields
type ExtendedReports struct
is a little hacky, but I wanted to leave the rest of the package code as untouched as possible. The different block types do not have different packet types, so header.go and packet.go would not be able to useh.Type
to see the different block types.I could refactor the code in other files to eliminate the need for the embedded struct.
I will format the code at the end when tests are passing and remove some comments.
I don't know if the extended_reports.go file is too large. The extended_reports_test.go file might end up being very large as well. I can parse these files out into different files and/or make new directory with new package name (e.g. package xr)
First thing tomorrow night I'm going to use wireshark to get packet dump from a linphone call (which is supposed to be unencrypted) to get example data for tests. I have never done that, so if there is a better way, please comment below. If you want to help out, please comment below on what you want to work on.
I could be going about all this the wrong way or this issue is outdated and there is no longer need or want for extended reports. If someone could confirm extended reports is still a good idea, that would be great.
Thanks :)
#8