Implement selective update for HostAgentBean and add unit tests #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweedeldee
approved these changes
Dec 20, 2024
Comment on lines
+66
to
+71
| public void updateChanged(String hostId, HostAgentBean oldBean, HostAgentBean newBean) | ||
| throws SQLException { | ||
| SetClause setClause = | ||
| oldBean == null ? newBean.genSetClause() : newBean.genChangedSetClause(oldBean); | ||
| String clause = String.format(UPDATE_HOST_BY_ID, setClause.getClause()); | ||
| setClause.addValue(id); | ||
| setClause.addValue(hostId); |
There was a problem hiding this comment.
passing the hostId as a parameter while it's already contained in both beans is a bit weird, but I guess it can serve as outlining how special that field is ?
I can't tell if I like it or hate it, so I'm ok with status quo.
osoriano
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
deploy-servicemodule, focusing on updating theHostAgentBeanclass and related components to support partial updates. The most important changes include adding a new method to generate a set clause for changed fields, modifying theHostAgentDAOandDBHostAgentDAOImplclasses to use this new method, and updating thePingHandlerclass to utilize these changes. Additionally, a new test class forHostAgentBeanhas been added.Enhancements to
HostAgentBean:deploy-service/common/src/main/java/com/pinterest/deployservice/bean/HostAgentBean.java: AddedtoBuilder = trueto the@Builderannotation and introduced thegenChangedSetClausemethod to generate a set clause for only the changed fields. Also added theaddChangedColumnhelper method. [1] [2]Updates to DAO classes:
deploy-service/common/src/main/java/com/pinterest/deployservice/dao/HostAgentDAO.java: Added theupdateChangedmethod to update only the non-null changed fields of aHostAgentBean.deploy-service/common/src/main/java/com/pinterest/deployservice/db/DBHostAgentDAOImpl.java: Modified theupdatemethod to use the newgenChangedSetClausemethod and renamed it toupdateChangedto reflect the new functionality.Changes to
PingHandler:deploy-service/common/src/main/java/com/pinterest/deployservice/handler/PingHandler.java: Removed unused DAO fields and updated theupdateHostStatusmethod to use the newupdateChangedmethod inHostAgentDAO. [1] [2] [3] [4] [5] [6]New test class:
deploy-service/common/src/test/java/com/pinterest/deployservice/bean/HostAgentBeanTest.java: Added a new test class to verify the functionality of thegenChangedSetClausemethod.These changes improve the efficiency of updates to
HostAgentBeanby ensuring that only the modified fields are updated in the database.