Abstracting out logic for TransactionManager reflections and direct field access; Disallow >1 backendProducers to be created when PscProducer is transactional #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psc/src/main/java/com/pinterest/psc/producer/transaction/KafkaTransactionManagerOperator.java
Outdated
Show resolved
Hide resolved
jeffxiang
changed the title
vahidhashemian
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new utility class
TransactionManagerUtilswhich centralizes and abstracts direct field access and reflections logic for Kafka's TransactionManager so that PSC's references can be backend-agnostic.PscProducer.send()will throw an exception if the following condition is true: The user is attempting to send a message via an already transactionalPscProducer, and if sending the message will result in the creation of an additional backendProducer when one already exists. If the producer is non-transactional at the time ofsend(), there is no enforcement.See javadocs for more details.