Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an internal subscribe call to MemQ consumer's assign() #38

Conversation

vahidhashemian
Copy link
Contributor

The native MemQ consumer expects an assign call to have a preceding subscribe call for the involved topics. With this PR, we implement this requirement in PscMemqConsumer class.

The new unit test would have failed without this addition.

@vahidhashemian vahidhashemian requested a review from a team as a code owner June 20, 2024 17:24
@vahidhashemian vahidhashemian merged commit 6da931c into pinterest:main Jun 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants