Merge latest changes in main to analytics-models feature-dev branch #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update generated client to 0.1.7 * Fix null configs for converion_tag * Linting * Feature fix/conversion tag configs (#83) * Linting * Update test
Calling <entity>.get_all() would return a list of entities and a Bookmark model that returns a new entity_list on each Bookmark.get_next() call which performs API calls only when necessary to fetch a new set, and eventually returns all entities for the parent.
As a result of the `PinterestBaseModel.__init__` getting called without the passed in client from the `Ad` model constructor, the requests failed resulting in an Auth error. This PR should fix the problem.
As integration_tests was a folder too, a PHONY target needed to be added for the makefile target.
* Update conversion tag * Update conversion event * Update pin model
* fix: test board * fix: test board * fix: change media to base64 * fix: typo random (#101) * fix: typo * Fix: typo
* Fix integration test set up * Fix lint error
* Fix bug for following bookmark on list_pins in Board model * Don't pass params if cls present
* Generate docs 0.2.1 * Update doc versioning
…123) * fix to incorrect error message when wrong refresh token is passed in * integration test
SparrowWhiteElkRaven
approved these changes
Dec 8, 2023
SparrowWhiteElkRaven
approved these changes
Feb 14, 2024
SparrowWhiteElkRaven
approved these changes
Feb 14, 2024
SparrowWhiteElkRaven
approved these changes
Feb 14, 2024
SparrowWhiteElkRaven
approved these changes
Feb 14, 2024
* fix: update generated client, fix tests and improve organic data
* fix lint
* fix: unit test
* fix: remove _targeting_template_ids from campaigns
---------
Co-authored-by: dfana <{ID}+{username}@users.noreply.github.com>
Co-authored-by: dfana <{ID}+{username}@users.noreply.github.com>
* Update setup.py to use the latest generated client
We upgraded the python client but missed the requirement in setup
* update sdk version
---------
Co-authored-by: dfana <{ID}+{username}@users.noreply.github.com>
campaign_update_request should be a list instead of a single campaign request
Fixed bug that affects campaign.set_lifetime_budget() Fix is in #140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.