Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor memqbroker classes #286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor memqbroker classes #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc2bdd4
split long method 'runAction'
Abhiram98 Aug 4, 2024
80d8066
split long method 'decomission'
Abhiram98 Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...ver/src/main/java/com/pinterest/orion/core/actions/memq/MemqBrokerDecommissionAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ public boolean decommission(Node node) throws Exception {
getResult().appendOut("Host " + hostName + " is in pending termination status.");
// Wait for the host to terminate. Check every 5 minutes for 30 minutes.
// If the host is still not terminated after 30 minutes, mark the action as failed.
if (waitForTermination(clusterId, instanceId, hostName)) return false;
// Remove the node from the Orion cluster and mark the action as succeeded
super.decommission(node);
markSucceeded();
return true;
}

private boolean waitForTermination(String clusterId, String instanceId, String hostName) throws InterruptedException {
long startTime = System.currentTimeMillis();
while (true) {
Thread.sleep(getTerminationCheckTimeIntervalMs());
Expand All @@ -49,15 +57,12 @@ public boolean decommission(Node node) throws Exception {
} else if (elapsedTime > getTerminationCheckTimeoutMs()) {
markFailed(String.format("Timed out waiting for host %s(%s) in cluster %s to terminate.",
hostName, instanceId, clusterId));
return false;
return true;
}
getResult().appendOut(String.format("Host %s(%s) in cluster %s is still terminating after %d ms.",
hostName, instanceId, clusterId, elapsedTime));
}
// Remove the node from the Orion cluster and mark the action as succeeded
super.decommission(node);
markSucceeded();
return true;
return false;
}

@Override
Expand Down
61 changes: 35 additions & 26 deletions ...rver/src/main/java/com/pinterest/orion/core/actions/memq/MemqBrokerReplacementAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,34 +40,15 @@ public void runAction() throws Exception {
markFailed(String.format("Failed to replace host %s(%s) in cluster %s.",
hostName, instanceId, clusterId));
}
// Check if the host is pending termination.
// The host should be in pending termination status after the API call.
Thread.sleep(getPostTerminationCheckWaitTimeMs());
if (!getEC2Helper().isHostPendingTermination(hostName)) {
markFailed(String.format("Failed post termination check for host %s(%s) in cluster %s.",
hostName, instanceId, clusterId));
}
getResult().appendOut("Host " + hostName + " is in pending termination status.");
// Wait for the host to terminate.
long startTime = System.currentTimeMillis();
while (true) {
Thread.sleep(getTerminationCheckTimeIntervalMs());
long elapsedTime = System.currentTimeMillis() - startTime;
if (getEC2Helper().isHostTerminated(hostName)) {
getResult().appendOut(String.format("Host %s(%s) in cluster %s has been terminated.",
hostName, instanceId, clusterId));
break;
} else if (elapsedTime > getTerminationCheckTimeoutMs()) {
markFailed(String.format("Timed out waiting for host %s(%s) in cluster %s to terminate.",
hostName, instanceId, clusterId));
break;
}
getResult().appendOut(String.format("Host %s(%s) in cluster %s is still terminating after %d ms.",
hostName, instanceId, clusterId, elapsedTime));
}
long startTime = waitForHostTermination(clusterId, instanceId, hostName);
// Wait for the replacement host to be added to the cluster.
// If the broker count is >= the initial count, the replacement is successful.
node.getCluster().getNodeMap().remove(node.getCurrentNodeInfo().getNodeId());
waitForReplacementHost(clusterId, startBrokerCount, startTime);
markSucceeded();
}

private void waitForReplacementHost(String clusterId, int startBrokerCount, long startTime) throws InterruptedException {
while (true) {
int currentBrokerCount = getRunningBrokerCount(getClusterBrokerPrefix(clusterId));
long elapsedTime = System.currentTimeMillis() - startTime;
Expand All @@ -93,7 +74,35 @@ public void runAction() throws Exception {
Thread.sleep(getReplacementCheckTimeIntervalMs());
}
getResult().appendOut("Successfully replace node " + nodeId + " in cluster " + clusterId);
markSucceeded();
}

private long waitForHostTermination(String clusterId, String instanceId, String hostName) throws InterruptedException {
// Check if the host is pending termination.
// The host should be in pending termination status after the API call.
Thread.sleep(getPostTerminationCheckWaitTimeMs());
if (!getEC2Helper().isHostPendingTermination(hostName)) {
markFailed(String.format("Failed post termination check for host %s(%s) in cluster %s.",
hostName, instanceId, clusterId));
}
getResult().appendOut("Host " + hostName + " is in pending termination status.");
// Wait for the host to terminate.
long startTime = System.currentTimeMillis();
while (true) {
Thread.sleep(getTerminationCheckTimeIntervalMs());
long elapsedTime = System.currentTimeMillis() - startTime;
if (getEC2Helper().isHostTerminated(hostName)) {
getResult().appendOut(String.format("Host %s(%s) in cluster %s has been terminated.",
hostName, instanceId, clusterId));
break;
} else if (elapsedTime > getTerminationCheckTimeoutMs()) {
markFailed(String.format("Timed out waiting for host %s(%s) in cluster %s to terminate.",
hostName, instanceId, clusterId));
break;
}
getResult().appendOut(String.format("Host %s(%s) in cluster %s is still terminating after %d ms.",
hostName, instanceId, clusterId, elapsedTime));
}
return startTime;
}

@Override
Expand Down