Publish snapshots build against kotlin dev versions. #809
Conversation
build.gradle
Outdated
| @@ -23,6 +22,10 @@ ext.deps = [ | |||
| 'jimfs' : 'com.google.jimfs:jimfs:1.1' | |||
| ] | |||
|
|
|||
| if (gradle.ext.isKotlinDev) { | |||
| project.properties.put("VERSION_NAME", "0.38.0-kotlin-dev-SNAPSHOT") | |||
There was a problem hiding this comment.
Shouldn't the version number be dynamic?
There was a problem hiding this comment.
-SNAPSHOT means it will be dynamic
There was a problem hiding this comment.
@Tapchicoma agree here. Can we pull the main version name from the gradle.properties file or something? Otherwise we have to remember to update 0.38.0 in 2 places when we next release.
There was a problem hiding this comment.
sorry, missed here main point. Will update code to pull it from gradle.properties
There was a problem hiding this comment.
Fixed via 8f4fa13
Tapchicoma
force-pushed
the
publish-dev-kotlin-snapshots
branch
from
4b18702 to
050f9e5
Compare
Signed-off-by: Yahor Berdnikau <[email protected]>
This allows to publish snapshots build against kotlin dev version. Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
This repository is not needed, 'maven-publish' actually adds it automatically. Signed-off-by: Yahor Berdnikau <[email protected]>
| } | ||
| } | ||
|
|
||
| // Pass '-PkotlinDev' to command line to enable kotlin-in-development version |
There was a problem hiding this comment.
Will you also update CI script to publish with kotlinDev on master?
There was a problem hiding this comment.
Already done, please check latest changes.
build.gradle
Outdated
|
|
||
| if (gradle.ext.isKotlinDev) { | ||
| maven { url 'https://dl.bintray.com/kotlin/kotlin-eap' } | ||
| maven { url 'https://kotlin.bintray.com/kotlinx' } |
There was a problem hiding this comment.
Do we actually need kotlinx repo?
There was a problem hiding this comment.
Seems added while I was testing building against dev version and forgot to remove. Removed in 3a8a398
build.gradle
Outdated
| @@ -23,6 +22,12 @@ ext.deps = [ | |||
| 'jimfs' : 'com.google.jimfs:jimfs:1.1' | |||
| ] | |||
|
|
|||
| if (gradle.ext.isKotlinDev) { | |||
| allprojects { p -> | |||
| p.ext."VERSION_NAME" = "0.38.0-kotlin-dev-SNAPSHOT" | |||
There was a problem hiding this comment.
I think I would be also in favour of having kotlin version in the version name in case of a snapshot. Otherwise you'd always need to look up in this file, which kotlin version has been used to build the snapshot. Or maybe we could have a badge in readme to show the kotlin-dev version?
There was a problem hiding this comment.
I would prefer to not add it in version name, as you need always check if it is changed.
Badge could be an option and definitely changelog updates.
Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
It will use proper dependency on maven publish tasks. Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
It is a bug in Dokka, see Kotlin/dokka#294 Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
Signed-off-by: Yahor Berdnikau <[email protected]>
Adds support for
-PkotlinDevflag. This flag enables building ktlint against Kotlin development versions.Additionally allows to publish this project snapshots that are built against dev versions. To be able to do that have to migrate publishing from 'com.vanniktech.maven.publish' plugin to generic Gradle 'maven-publish'.
Kotlin release and dev versions should be updated now in two places -
build.gradleandsettings.gradle. Will simplify this in the future.