Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-apply #1129 with fixes for regressions #1201

Merged
merged 5 commits into from
Aug 6, 2021

Conversation

shashachu
Copy link
Contributor

  • Used imports state has to be reset per-file

Description

  • A regression was introduced to the no-unused-imports rule where it would report false positives
  • Add auto-correction to the case of repeated imports

Checklist

  • tests are added

- Used imports state has to be reset per-file
- Allow repeated imports to be auto-corrected
@shashachu shashachu changed the title Fix regressions introduced in #1129 Re-apply #1129 with fixes for regressions Aug 6, 2021
@shashachu shashachu merged commit 29e3ef5 into pinterest:master Aug 6, 2021
romtsn pushed a commit to paul-dingemans/ktlint that referenced this pull request Aug 8, 2021
* Fix regressions introduced in pinterest#1129

- Used imports state has to be reset per-file
- Allow repeated imports to be auto-corrected

* fix lint

* Fix bad merge conflict

* more merge fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant