Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masonry: Multicolumn integration test remove unused typescript suppression errors #4015

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

JosAnGoCa
Copy link
Contributor

Summary

This PR focuses on optimizing our integration test setup by removing redundant TypeScript error suppression comments in Playwright tests. Additionally, it introduces logic to verify and create a directory for storing scroll performance metrics.

What changed?

  • Eliminated all superfluous TypeScript error suppression comments in the integration test utilities.
  • Added code to ensure the directory structure exists for saving scroll performance test results:
const scrollPerformanceResultsFilePath = 'playwright/test-results/scroll-performance-results.json';
const dir = dirname(scrollPerformanceResultsFilePath);

if (!existsSync(dir)) {
  mkdirSync(dir, { recursive: true });
}

Why?

These changes were necessary to eliminate unnecessary error suppression, improve code clarity, and resolve an issue related to local test execution.

Checklist

  • Fix test
  • Remove unnecessary error suppressions

@JosAnGoCa JosAnGoCa requested a review from a team as a code owner February 26, 2025 21:57
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ef976de
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/67bf8e2f47a7f200086669f7
😎 Deploy Preview https://deploy-preview-4015--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AlbertCarreras AlbertCarreras added the patch release Patch release label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants