Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Upgrade React to 18.3.1 #3935

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

pabmacias
Copy link
Contributor

@pabmacias pabmacias commented Jan 10, 2025

Summary

What changed?

Upgrading React Version to 18.3.1

Why?

We need to upgrade Gestalt to React 19. In order to prepare for this we are first upgrading to React 18.3 which still works the same as 18.2 but it sends warnings on braking changes for React 19. We will be collecting this warnings and make the necessary changes for the next upgrade.

Links

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@pabmacias pabmacias changed the title Upgrade to react 18.2.0 Internal: Upgrade React to 18.2.0 Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for gestalt ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b300ea
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/67855ee1ff108700080c3e72
😎 Deploy Preview https://deploy-preview-3935--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pabmacias pabmacias marked this pull request as ready for review January 13, 2025 18:54
@pabmacias pabmacias requested a review from a team as a code owner January 13, 2025 18:54
@pabmacias pabmacias changed the title Internal: Upgrade React to 18.2.0 Internal: Upgrade React to 18.3.1 Jan 13, 2025
@AlbertCarreras AlbertCarreras added the patch release Patch release label Jan 13, 2025
@AlbertCarreras AlbertCarreras merged commit eeef0cf into pinterest:master Jan 13, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants