Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner: VR color variants #3912

Merged
merged 8 commits into from
Jan 14, 2025
Merged

Spinner: VR color variants #3912

merged 8 commits into from
Jan 14, 2025

Conversation

diyorbek
Copy link
Contributor

Summary

Added new color variants for VR Spinner.

color="white"
Screenshot 2024-12-16 at 22 38 21

color="grayscale"
Screenshot 2024-12-16 at 22 38 16

Links

Checklist

  • Added unit tests
  • Added documentation + accessibility tests
  • Verified accessibility: keyboard & screen reader interaction
  • Checked dark mode, responsiveness, and right-to-left support
  • Checked stakeholder feedback (e.g. Gestalt designers, relevant feature teams)

@diyorbek diyorbek requested a review from a team as a code owner December 16, 2024 17:39
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit 5345569
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/676065f10a827000083eeb23
😎 Deploy Preview https://deploy-preview-3912--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for gestalt ready!

Name Link
🔨 Latest commit dbae215
🔍 Latest deploy log https://app.netlify.com/sites/gestalt/deploys/6786871a63cdd20008611683
😎 Deploy Preview https://deploy-preview-3912--gestalt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diyorbek diyorbek added the minor release Minor release label Dec 16, 2024
Copy link
Contributor

@rlingineni rlingineni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but see suggestion on not introducing one-off component tokens

packages/gestalt/src/Spinner/VRSpinner.css Outdated Show resolved Hide resolved
@diyorbek diyorbek enabled auto-merge (squash) January 14, 2025 15:48
@diyorbek diyorbek merged commit 150ef85 into master Jan 14, 2025
13 checks passed
@diyorbek diyorbek deleted the spinner-color-variants branch January 14, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor release Minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants