This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Add broker decommission api #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyang08
approved these changes
May 8, 2019
ambud
suggested changes
May 9, 2019
drkafka/src/main/java/com/pinterest/doctorkafka/KafkaClusterManager.java
Show resolved
Hide resolved
drkafka/src/main/java/com/pinterest/doctorkafka/api/DecommissionBrokerApi.java
Outdated
Show resolved
Hide resolved
drkafka/src/main/java/com/pinterest/doctorkafka/api/DecommissionBrokerApi.java
Outdated
Show resolved
Hide resolved
ambud
reviewed
May 9, 2019
drkafka/src/main/java/com/pinterest/doctorkafka/api/DecommissionBrokerApi.java
Outdated
Show resolved
Hide resolved
kabochya
force-pushed
the
feature/broker-decommission-api
branch
7 times, most recently
from
b7d0d3d to
bce2838
Compare
add email notifications for decommissioning refactor api code make broker api return decommission info, refactored getters to comply with convention, reordering to group getter/setters modify UI to expose decommission status
kabochya
force-pushed
the
feature/broker-decommission-api
branch
from
bce2838 to
5676eba
Compare
ambud
approved these changes
May 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Currently, a decommissioned broker
Decommissioning is ephemeral for now, state is not preserved in ZK, so if a restart happens, we will have to do it again