This repository has been archived by the owner on Dec 16, 2021. It is now read-only.
Fix #18 duplicate reassignment #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could we start with adding a unit test that can reproduce the issue? |
yuyang08
reviewed
Mar 15, 2019
| @@ -599,9 +599,10 @@ public UnderReplicatedReason getUnderReplicatedReason(String brokerHost, | |||
| List<OutOfSyncReplica> outOfSyncReplicas) { | |||
| Map<TopicPartition, Integer[]> replicasMap = new HashMap<>(); | |||
| boolean success = true; | |||
|
|
|||
| PriorityQueue<KafkaBroker> brokerQueue = kafkaCluster.getBrokerQueue(); | |||
There was a problem hiding this comment.
brokerQueue is used in KafkaCluster.getAlternativeBrokers, and the priority queue ordering invariant is maintained in that method.
| for (OutOfSyncReplica oosReplica : outOfSyncReplicas) { | ||
| // rebuild broker queue each time to get up-to-date results | ||
| brokerQueue = kafkaCluster.getBrokerQueue(); |
There was a problem hiding this comment.
kafkaCluster.getBrokerQueue() is an expensive operation. As long as we maintain the priority queue ordering invariant, we do not need to recompute the priority queue for each out of sync replica.
…orkafka into fix-duplicate-reassignment
|
Test added to reproduce issue, updated fix to avoid costly operations. |
yuyang08
reviewed
Mar 16, 2019
|
@kabochya Thanks for making the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #18
Duplicate reassignment will happen when multiple outOfSyncReplicas exist and target broker is still least used broker.
Creating the broker queue each time so we don't need to deal with recovering the brokerQueue for next outOfSyncReplica