Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] fix plugin package class requirement filter #9672

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

donghun-cho
Copy link
Contributor

to use correct classloader

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #9672 (ae607e5) into master (0e54106) will decrease coverage by 0.01%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #9672      +/-   ##
============================================
- Coverage     38.94%   38.93%   -0.01%     
+ Complexity    11920    11916       -4     
============================================
  Files          3494     3494              
  Lines         93775    93775              
  Branches      10519    10519              
============================================
- Hits          36520    36511       -9     
- Misses        54080    54088       +8     
- Partials       3175     3176       +1     
Impacted Files Coverage Δ
...profiler/plugin/PinpointProfilerPackageFilter.java 0.00% <ø> (ø)
...iler/plugin/PinpointProfilerPackageSkipFilter.java 90.47% <ø> (ø)
.../pinpoint/profiler/plugin/PluginPackageFilter.java 80.00% <ø> (ø)
...strument/classloading/PlainClassLoaderHandler.java 53.45% <62.50%> (ø)
...er/plugin/PluginPackageClassRequirementFilter.java 80.64% <66.66%> (ø)
...pinpoint/profiler/plugin/ClassNameFilterChain.java 100.00% <100.00%> (ø)
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
.../pinpoint/rpc/client/PinpointClientHandshaker.java 59.66% <0.00%> (-2.53%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@donghun-cho donghun-cho merged commit 07cc30a into pinpoint-apm:master Jan 31, 2023
@donghun-cho donghun-cho deleted the plugin-fix branch February 1, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant