Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9614] Apply temporary fix to Pinot #9614 issue #9615

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

ga-ram
Copy link
Contributor

@ga-ram ga-ram commented Jan 9, 2023

This fix still doesn't handle the case in which query itself has fixed parameters which includes ?.
To handle that case fillStatementWithParameters also has to check if ? is within '.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #9615 (6119dfc) into master (0a049cc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9615      +/-   ##
============================================
- Coverage     38.95%   38.94%   -0.01%     
- Complexity    11903    11911       +8     
============================================
  Files          3487     3487              
  Lines         93627    93691      +64     
  Branches      10514    10520       +6     
============================================
+ Hits          36473    36490      +17     
- Misses        53992    54045      +53     
+ Partials       3162     3156       -6     
Impacted Files Coverage Δ
...inot/datasource/WrappedPinotPreparedStatement.java 0.00% <0.00%> (ø)
...pinpoint/rpc/ChannelWriteFailListenableFuture.java 42.85% <0.00%> (-28.58%) ⬇️
...n/server/bo/serializer/trace/v2/SpanDecoderV0.java 81.73% <0.00%> (+0.45%) ⬆️
...n/server/bo/serializer/trace/v2/SpanEncoderV0.java 83.42% <0.00%> (+0.53%) ⬆️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.89% <0.00%> (+0.82%) ⬆️
...point/rpc/client/DefaultPinpointClientHandler.java 71.83% <0.00%> (+1.40%) ⬆️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 77.54% <0.00%> (+1.60%) ⬆️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 53.33% <0.00%> (+1.66%) ⬆️
.../navercorp/pinpoint/rpc/client/RequestManager.java 74.24% <0.00%> (+7.57%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad added this to the 2.5.1 milestone Jan 9, 2023
@emeroad emeroad linked an issue Jan 9, 2023 that may be closed by this pull request
@emeroad emeroad closed this Jan 9, 2023
@emeroad emeroad reopened this Jan 9, 2023
@ga-ram ga-ram merged commit 00fa07c into pinpoint-apm:master Jan 9, 2023
@ga-ram ga-ram deleted the 9614 branch January 9, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply temporary fix to Pinot #6834 issue
2 participants