Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9575] Polishing #9613

Merged
merged 2 commits into from
Jan 9, 2023
Merged

[#9575] Polishing #9613

merged 2 commits into from
Jan 9, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jan 6, 2023

No description provided.

@emeroad emeroad added this to the 2.5.1 milestone Jan 6, 2023
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #9613 (bd341fc) into master (dc60c05) will increase coverage by 0.00%.
The diff coverage is 27.94%.

@@            Coverage Diff            @@
##             master    #9613   +/-   ##
=========================================
  Coverage     38.97%   38.98%           
- Complexity    11907    11908    +1     
=========================================
  Files          3482     3484    +2     
  Lines         93618    93592   -26     
  Branches      10525    10523    -2     
=========================================
- Hits          36489    36485    -4     
+ Misses        53965    53949   -16     
+ Partials       3164     3158    -6     
Impacted Files Coverage Δ
...orp/pinpoint/profiler/context/AsyncChildTrace.java 1.85% <0.00%> (+0.01%) ⬆️
...p/pinpoint/profiler/context/AsyncDefaultTrace.java 0.00% <0.00%> (ø)
...profiler/context/recorder/DefaultSpanRecorder.java 22.64% <0.00%> (-2.36%) ⬇️
...ofiler/context/recorder/TraceRootSpanRecorder.java 0.00% <0.00%> (ø)
...inpoint/profiler/context/DefaultCloseListener.java 16.66% <16.66%> (ø)
...oint/profiler/context/DefaultBaseTraceFactory.java 51.68% <43.75%> (+2.21%) ⬆️
...filer/context/recorder/DefaultRecorderFactory.java 71.42% <50.00%> (ø)
...ercorp/pinpoint/profiler/context/DefaultTrace.java 58.92% <83.33%> (-2.15%) ⬇️
...rcorp/pinpoint/profiler/context/CloseListener.java 100.00% <100.00%> (ø)
...p/pinpoint/rpc/stream/StreamChannelRepository.java 57.89% <0.00%> (-21.06%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad force-pushed the #9595_async_state branch from 74275da to 01e7af3 Compare January 6, 2023 10:23
@emeroad emeroad changed the title [#9575] Remove unnecessary sampling flag [#9575] Polishing Jan 6, 2023
@emeroad emeroad force-pushed the #9595_async_state branch from 01e7af3 to f0fdbce Compare January 6, 2023 10:24
@emeroad emeroad force-pushed the #9595_async_state branch 2 times, most recently from bbfd377 to bd341fc Compare January 7, 2023 04:05
@emeroad emeroad merged commit 44466a8 into pinpoint-apm:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve async state propagation of non sampling state for full statistics
1 participant