Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9482] Await termination of grpc server #9483

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Dec 7, 2022

resolves #9482

@smilu97 smilu97 self-assigned this Dec 7, 2022
@smilu97 smilu97 marked this pull request as draft December 7, 2022 07:07
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #9483 (d7251d9) into master (b5e84d1) will increase coverage by 0.01%.
The diff coverage is 8.00%.

@@             Coverage Diff              @@
##             master    #9483      +/-   ##
============================================
+ Coverage     38.91%   38.93%   +0.01%     
- Complexity    11751    11757       +6     
============================================
  Files          3446     3446              
  Lines         92297    92303       +6     
  Branches      10263    10265       +2     
============================================
+ Hits          35917    35934      +17     
+ Misses        53270    53261       -9     
+ Partials       3110     3108       -2     
Impacted Files Coverage Δ
...grpc/config/GrpcPropertiesServerOptionBuilder.java 82.14% <0.00%> (-6.32%) ⬇️
...pinpoint/collector/receiver/grpc/GrpcReceiver.java 0.00% <0.00%> (ø)
...m/navercorp/pinpoint/grpc/server/ServerOption.java 79.34% <25.00%> (+17.60%) ⬆️
...llector/grpc/config/GrpcReceiverConfiguration.java 67.74% <0.00%> (-2.63%) ⬇️
...avercorp/pinpoint/profiler/context/AsyncTrace.java 0.00% <0.00%> (ø)
...ercorp/pinpoint/profiler/context/DisableTrace.java 52.77% <0.00%> (ø)
...filer/context/recorder/DefaultUriStatRecorder.java 0.00% <0.00%> (ø)
...tor/grpc/config/GrpcSpanReceiverConfiguration.java 100.00% <0.00%> (ø)
...tor/grpc/config/GrpcStatReceiverConfiguration.java 100.00% <0.00%> (ø)
...r/context/storage/AsyncQueueingUriStatStorage.java 78.68% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 requested a review from emeroad December 8, 2022 02:29
@smilu97 smilu97 marked this pull request as ready for review December 8, 2022 02:29
@smilu97 smilu97 requested a review from emeroad December 8, 2022 06:41
@smilu97 smilu97 merged commit 69fa776 into pinpoint-apm:master Dec 12, 2022
@smilu97 smilu97 deleted the #9482_grace branch December 12, 2022 06:46
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance graceful shutdown
2 participants