Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9217] Change distribution logic for kafka key in collector #9222

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

minwoo-jung
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #9222 (bf45093) into master (6904b75) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head bf45093 differs from pull request most recent head 8084d24. Consider uploading reports for the commit 8084d24 to get more accurate results

@@             Coverage Diff              @@
##             master    #9222      +/-   ##
============================================
- Coverage     39.87%   39.86%   -0.02%     
+ Complexity    11775    11770       -5     
============================================
  Files          3364     3364              
  Lines         90762    90762              
  Branches      10093    10093              
============================================
- Hits          36194    36179      -15     
- Misses        51479    51492      +13     
- Partials       3089     3091       +2     
Impacted Files Coverage Δ
.../metric/collector/dao/pinot/PinotMetricTagDao.java 0.00% <0.00%> (ø)
...ollector/dao/pinot/PinotSystemMetricDoubleDao.java 0.00% <0.00%> (ø)
.../pinpoint/rpc/packet/stream/StreamClosePacket.java 57.14% <0.00%> (-25.00%) ⬇️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 57.89% <0.00%> (-21.06%) ⬇️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
.../pinpoint/metric/common/pinot/PinotDataSource.java 41.66% <0.00%> (-4.17%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (-0.83%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (+3.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@minwoo-jung minwoo-jung changed the title [#9176] Improved code so that connection object of pinot is reused in collector [#9217] Change distribution logic for kafka key in collector Sep 22, 2022
@minwoo-jung minwoo-jung merged commit a318f2e into pinpoint-apm:master Sep 22, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants