Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9157] Prevent initializing active thread workers multiple times #9158

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Aug 26, 2022

resolves #9157

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #9158 (7f43bde) into master (823b1e0) will increase coverage by 0.15%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##             master    #9158      +/-   ##
============================================
+ Coverage     39.61%   39.77%   +0.15%     
- Complexity    11684    11715      +31     
============================================
  Files          3355     3355              
  Lines         90475    90490      +15     
  Branches      10053    10053              
============================================
+ Hits          35846    35993     +147     
+ Misses        51583    51428     -155     
- Partials       3046     3069      +23     
Impacted Files Coverage Δ
...websocket/ActiveThreadCountResponseAggregator.java 40.76% <77.77%> (+40.76%) ⬆️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 78.60% <0.00%> (-2.47%) ⬇️
...avercorp/pinpoint/web/service/SpanServiceImpl.java 0.00% <0.00%> (ø)
...oint/web/websocket/ActiveThreadCountErrorType.java 93.54% <0.00%> (+9.67%) ⬆️
...rp/pinpoint/web/websocket/WorkerActiveManager.java 22.34% <0.00%> (+22.34%) ⬆️
...inpoint/web/websocket/ActiveThreadCountWorker.java 37.50% <0.00%> (+37.50%) ⬆️
...corp/pinpoint/web/cluster/ClusterKeyAndStatus.java 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 force-pushed the #9157_realtime_bug branch from a7ddcdc to eeba860 Compare August 30, 2022 08:34
@smilu97 smilu97 marked this pull request as ready for review August 30, 2022 08:34
@smilu97 smilu97 requested a review from emeroad August 31, 2022 05:18
Copy link
Member

@emeroad emeroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emeroad emeroad merged commit 8844619 into pinpoint-apm:master Sep 1, 2022
@smilu97 smilu97 deleted the #9157_realtime_bug branch September 2, 2022 06:17
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one user can use realtime-active-request feature on same machine and application
2 participants