Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8890] Merge all lib jars in custom filesystem #8931

Closed

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jun 16, 2022

To utilize ModulePath instead of our custom jar parser, it creates a small file system which can contain only one single file for combined jar file.

This custom small filesystem can work as a bridge between ModulePath and combined jar in memory.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #8931 (3a3afa9) into master (1dd05c8) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8931      +/-   ##
============================================
+ Coverage     39.91%   39.92%   +0.01%     
- Complexity    11652    11658       +6     
============================================
  Files          3272     3272              
  Lines         89734    89734              
  Branches       9986     9986              
============================================
+ Hits          35821    35830       +9     
+ Misses        50843    50836       -7     
+ Partials       3070     3068       -2     
Impacted Files Coverage Δ
.../navercorp/pinpoint/rpc/client/RequestManager.java 66.66% <0.00%> (-7.58%) ⬇️
...orp/pinpoint/profiler/sender/NioUDPDataSender.java 62.82% <0.00%> (-5.13%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 75.93% <0.00%> (-2.14%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 21.59% <0.00%> (+1.13%) ⬆️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (+1.23%) ⬆️
...point/rpc/client/DefaultPinpointClientHandler.java 71.83% <0.00%> (+1.40%) ⬆️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 53.33% <0.00%> (+6.66%) ⬆️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+7.40%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd05c8...3a3afa9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment