Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8904] Fix broken binary compatibility of THRIFT 0.13 of thrift plugin #8910

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 3, 2022

No description provided.

@emeroad emeroad linked an issue Jun 3, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #8910 (4f6d57d) into master (a9b7793) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8910      +/-   ##
============================================
+ Coverage     39.94%   39.95%   +0.01%     
  Complexity    11653    11653              
============================================
  Files          3272     3272              
  Lines         89733    89733              
  Branches       9986     9986              
============================================
+ Hits          35841    35851      +10     
+ Misses        50826    50817       -9     
+ Partials       3066     3065       -1     
Impacted Files Coverage Δ
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 68.51% <0.00%> (-7.41%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (+1.23%) ⬆️
...tor/metric/datasource/DefaultDataSourceMetric.java 88.88% <0.00%> (+3.70%) ⬆️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 53.33% <0.00%> (+6.66%) ⬆️
...r/context/storage/AsyncQueueingUriStatStorage.java 85.29% <0.00%> (+16.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b7793...4f6d57d. Read the comment docs.

@emeroad emeroad merged commit 774b544 into pinpoint-apm:master Jun 7, 2022
@emeroad emeroad deleted the #8904_thrift_comp branch June 15, 2022 04:16
@emeroad emeroad added the dependencies Pull requests that update a dependency file label Dec 26, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken binary compatibility of THRIFT 0.13 of thrift plugin
1 participant