[#noissue] PinpointPluginTestSuite JDK9+ compatibility #7415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emeroad
reviewed
Nov 13, 2020
| return getClassPathList(cl, classPathCandidates); | ||
| } | ||
|
|
||
| private List<String> getJava9ClassPathList(String[] classPathCandidates) { |
There was a problem hiding this comment.
The design of classloader dependent code seems to be bad.
If everything is fine, your code looks much better.
Could you replace the old code with yours?
cl = cl.getParent();
if (cl == null) {
break;
}There may be a problem with the above code, but I'm not sure.
Please check that it works properly in all tests.
There was a problem hiding this comment.
Thank you for your review @emeroad
I'll change the old code and make sure there are no problems with all the tests.
When this test is completed i will commit again :)
This was referenced Nov 14, 2022
|
resolved in #9416. Thank you for issuing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the plugin integration test, I found that PinpointPluginTestSuite doesn't work on jdk9+.
I modified this so that it can be executed on jdk9+.
Please let me know if it's a issue to be resolved directly by team or if it's not within the scope of pinpoint support.
Then I'll close it.
1. In jdk 9+ environment, the
SharedProcessManager.fork()running command does not have -cp argument.This is because of the ClassLoader changed from jdk9+.
So i modified not to use URLClassLoader in jdk9+.
2. When using @JvmVersion(9+) annontation
class com.navercorp.pinpoint.bootstrapAgentBootLoader$1 cannot access class com.navercorp.pinpoint.test.PluginTestAgent exception occurred
This is because the PluginTestAgent cannot be accessed from the external module. So I added it to the export list.
Thank you.