Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] fix: keyboard event propagation #11266

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[#noissue] fix: keyboard event propagation #11266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion web-frontend/src/main/v3/packages/datetime-picker/src/utils/useCaptureKeydown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as React from 'react';

export const useCaptureKeydown = (callback: (event: KeyboardEvent) => void) => {
const handleKeydown = (e: KeyboardEvent) => {
e.stopPropagation();
callback?.(e);
};

Expand Down
1 change: 0 additions & 1 deletion web-frontend/src/main/v3/packages/hooks/src/utility/useCaptureKeydown.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import * as React from 'react';

export const useCaptureKeydown = (callback: (event: KeyboardEvent) => void) => {
const handleKeydown = (e: KeyboardEvent) => {
e.stopPropagation();
callback?.(e);
};

Expand Down
3 changes: 1 addition & 2 deletions web-frontend/src/main/v3/packages/ui/src/components/GlobalSearch/GlobalSearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export const GlobalSearch = ({ services }: GlobalSearchProps) => {
if (portalTargetElement) {
const down = (e: KeyboardEvent) => {
if (e.key === 'k' && (e.metaKey || e.ctrlKey)) {
e.preventDefault();
setOpen((open) => !open);
}
if (e.code === 'Escape' && open) {
Expand All @@ -47,7 +46,7 @@ export const GlobalSearch = ({ services }: GlobalSearchProps) => {
} else {
console.warn('Please register the target element for global search portal in root html');
}
}, [portalTargetElement]);
}, []);

const isTransactionId = (tid: string) => {
return transactionIdRegExp.test(tid.trim());
Expand Down