Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Replace XML in GRPC with java config #11226

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jul 8, 2024

No description provided.

@emeroad emeroad added the cleanup label Jul 8, 2024
@emeroad emeroad added this to the 3.0.1 milestone Jul 8, 2024
@emeroad emeroad force-pushed the #noissue_grpc_config branch from ee3f83f to 0da8d3b Compare July 10, 2024 06:41
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 83.91608% with 23 lines in your changes missing coverage. Please review.

Project coverage is 37.17%. Comparing base (58c70b9) to head (6ddfbf6).

Files Patch % Lines
...altime/collector/receiver/EmptyCommandService.java 0.00% 7 Missing ⚠️
.../collector/grpc/config/GrpcKeepAliveScheduler.java 0.00% 5 Missing ⚠️
...rpc/config/GrpcAgentDataReceiverConfiguration.java 94.87% 2 Missing ⚠️
...tor/grpc/config/GrpcSpanReceiverConfiguration.java 93.54% 1 Missing and 1 partial ⚠️
...tor/grpc/config/GrpcStatReceiverConfiguration.java 93.54% 1 Missing and 1 partial ⚠️
...pinpoint/collector/receiver/grpc/GrpcReceiver.java 60.00% 2 Missing ⚠️
...ercorp/pinpoint/grpc/server/AgentHeaderReader.java 0.00% 1 Missing ⚠️
...oint/grpc/server/HeaderPropagationInterceptor.java 0.00% 1 Missing ⚠️
...g/collector/grpc/LogCollectorGrpcServerConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11226      +/-   ##
============================================
+ Coverage     36.97%   37.17%   +0.19%     
- Complexity    12054    12139      +85     
============================================
  Files          3987     3990       +3     
  Lines         97947    98050     +103     
  Branches      10421    10417       -4     
============================================
+ Hits          36218    36446     +228     
+ Misses        58760    58631     -129     
- Partials       2969     2973       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad force-pushed the #noissue_grpc_config branch 2 times, most recently from c03d262 to 87a3d6e Compare July 10, 2024 11:14
@emeroad emeroad force-pushed the #noissue_grpc_config branch from 87a3d6e to 6ddfbf6 Compare July 11, 2024 06:41
@emeroad emeroad merged commit 5148be4 into pinpoint-apm:master Jul 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant