-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ContextCloser must not be rejected #9323
Comments
smilu97
pushed a commit
to smilu97/pinpoint
that referenced
this issue
Oct 25, 2022
smilu97
changed the title
HandleCommand events must not be rejected
ContextCloser must not be rejected
Oct 25, 2022
Changed policy to ignore leaking from rejection of onComplete event, but augment queue size. It only prevents ignoring ContextCloser which causes leak in the gRPC-managed resource pool. |
smilu97
pushed a commit
to smilu97/pinpoint
that referenced
this issue
Oct 25, 2022
smilu97
pushed a commit
to smilu97/pinpoint
that referenced
this issue
Oct 26, 2022
smilu97
pushed a commit
to smilu97/pinpoint
that referenced
this issue
Oct 27, 2022
smilu97
pushed a commit
to smilu97/pinpoint
that referenced
this issue
Oct 27, 2022
emeroad
pushed a commit
to smilu97/pinpoint
that referenced
this issue
Oct 27, 2022
emeroad
pushed a commit
that referenced
this issue
Oct 27, 2022
emeroad
added a commit
to emeroad/pinpoint
that referenced
this issue
Oct 28, 2022
emeroad
added a commit
that referenced
this issue
Oct 28, 2022
BillionaireDY
pushed a commit
to BillionaireDY/pinpoint
that referenced
this issue
Dec 29, 2022
BillionaireDY
pushed a commit
to BillionaireDY/pinpoint
that referenced
this issue
Dec 29, 2022
BillionaireDY
pushed a commit
to BillionaireDY/pinpoint
that referenced
this issue
Dec 29, 2022
BillionaireDY
pushed a commit
to BillionaireDY/pinpoint
that referenced
this issue
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
onComplete
listener in handleCommand must not be rejected for preventing memory leak.For now, there is no adequate way to distinguish
onNext
,onComplete
,onError
in prior, so we decided to use CachedThreadPool as the serverExecutor just for the handleCommand service, and not to reject any events from that.This action may temporarily applied, and be overrided by replacing every serverExecutor with CachedThreadPool because we have already checked most of heavy-IO jobs are being handed to another executors (worker executors), and so properly throttled.
The text was updated successfully, but these errors were encountered: