Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collector pend too many ping-tries #9264

Closed
smilu97 opened this issue Oct 13, 2022 · 1 comment · Fixed by #9266
Closed

Collector pend too many ping-tries #9264

smilu97 opened this issue Oct 13, 2022 · 1 comment · Fixed by #9266
Assignees
@smilu97
Labels
bug module:collector
Milestone
2.5.0

Comments

@smilu97
Copy link
Contributor

smilu97 commented Oct 13, 2022

agent service in collector continuously tries to send PPing grpc message to agent, but these are sometime blocked permanently, and pended in queue infinitely.

It needs to be suspended properly by checking the stream is busy at the time.

grpc already provides a method to check if stream is ready enough. (io.grpc.stub.ServerCallStreamObserver::isReady)
@smilu97 smilu97 self-assigned this Oct 13, 2022
@emeroad emeroad linked a pull request Oct 13, 2022 that will close this issue
[#9264] Guarded ping only when stream is ready #9266
Merged
@smilu97 smilu97 mentioned this issue Oct 13, 2022
Merged
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 13, 2022
[pinpoint-apm#9264] Guarded ping only when stream is ready
8c04203
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 13, 2022
[pinpoint-apm#9264] Guarded ping only when stream is ready
324a543
smilu97 pushed a commit that referenced this issue Oct 14, 2022
@smilu97
[#9264] Guarded ping only when stream is ready
587dc5c
@emeroad emeroad added the bug label Oct 14, 2022
@emeroad emeroad added this to the 2.5.0 milestone Oct 14, 2022
@emeroad
Copy link
Member

emeroad commented Dec 26, 2022

Related issue : pinpoint-apm/pinpoint-go-agent#26

BillionaireDY pushed a commit to BillionaireDY/pinpoint that referenced this issue Dec 29, 2022
@BillionaireDY
[pinpoint-apm#9264] Guarded ping only when stream is ready
3578b2b
BillionaireDY pushed a commit to BillionaireDY/pinpoint that referenced this issue Dec 29, 2022
@BillionaireDY
[pinpoint-apm#9264] Guarded ping only when stream is ready
470aff8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smilu97 smilu97

Labels
bug module:collector
Projects
None yet
Milestone
2.5.0
Development

Successfully merging a pull request may close this issue.

[#9264] Guarded ping only when stream is ready smilu97/pinpoint
2 participants
@emeroad @smilu97