-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify error responses in pinpoint web #8979
Comments
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Jun 28, 2022
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Jun 28, 2022
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Jun 29, 2022
ga-ram
added a commit
that referenced
this issue
Jun 29, 2022
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Jul 4, 2022
ga-ram
added a commit
that referenced
this issue
Jul 5, 2022
ga-ram
added a commit
to ga-ram/pinpoint
that referenced
this issue
Jul 11, 2022
… to keep all error responses in JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current implementation has more than 3 types of error responses in pinpoint web, and there is no written standards on how to handle error on failed requests.
I'd like to suggest throwing ResponseStatusException(
throw new ResponseStatusException(HttpStatus.xxx, "error message")
) when error occurs so that Spring can make the response data in its ErrorController.error response example:
This way, there is lower chance to see white label page error since front end will handle the responses with above format even when unexpected exceptions has occurred.
The text was updated successfully, but these errors were encountered: