Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PinpointNettyServerBuilder #10420

Closed
smilu97 opened this issue Oct 18, 2023 · 0 comments · Fixed by #10428
Closed

Deprecate PinpointNettyServerBuilder #10420

smilu97 opened this issue Oct 18, 2023 · 0 comments · Fixed by #10428
Assignees
@smilu97
Labels
module:collector

Comments

@smilu97
Copy link
Contributor

smilu97 commented Oct 18, 2023

Maintaining PinpointNettyServerBuilder seems hard, so we decided to deprecate PinpointNettyServerBuilder. The purpose of this will be alternated by using InternalChannelz.getRootChannels
@smilu97 smilu97 self-assigned this Oct 18, 2023
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 22, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
6e7cd47 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 22, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
ded5cfe 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 23, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
c513e7b 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 23, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
2b0433d 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 23, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
b5279e9 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 23, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
e0d9732 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 24, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
fe583cc 
… logId
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 24, 2023
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
cc20e5a 
… logId
smilu97 pushed a commit that referenced this issue Oct 24, 2023
@smilu97
[#10420] Removed PinpointNettyServerBuilder, Tracing gRPC logId
957f1ba
@smilu97 smilu97 linked a pull request Oct 24, 2023 that will close this issue
[#10420] Removed PinpointNettyServerBuilder, Tracing gRPC logId #10428
Merged
@smilu97 smilu97 closed this as completed Oct 24, 2023
smilu97 pushed a commit to smilu97/pinpoint that referenced this issue Oct 25, 2023
@smilu97
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
b10de33 
… logId
gipyeong-lee pushed a commit to gipyeong-lee/pinpoint that referenced this issue Nov 1, 2023
@gipyeong-lee
[pinpoint-apm#10420] Removed PinpointNettyServerBuilder, Tracing gRPC…
975bbb1 
… logId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smilu97 smilu97

Labels
module:collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#10420] Removed PinpointNettyServerBuilder, Tracing gRPC logId smilu97/pinpoint
1 participant
@smilu97