Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PApiMetaData.location #7

Closed
feelform opened this issue Jul 15, 2021 · 0 comments · Fixed by #10
Closed

Add PApiMetaData.location #7

feelform opened this issue Jul 15, 2021 · 0 comments · Fixed by #10
Milestone
2.3.1

Comments

@feelform
Copy link
Contributor

feelform commented Jul 15, 2021 •
edited
Loading

PApiMetaData.location use JS, java file location.

for Node
https://v8.dev/docs/stack-trace-api#appendix%3A-stack-trace-format

at Type.functionName [as methodName] (location)

a PApiMetaData.location is location in Node Stack trace format.

string location = 5;
@feelform feelform changed the title PApiMetaData.file add PApiMetaData.file Jul 15, 2021
@feelform feelform mentioned this issue Jul 15, 2021
Closed
@feelform feelform changed the title add PApiMetaData.file add PApiMetaData.location Jul 19, 2021
feelform added a commit to feelform/pinpoint-grpc-idl that referenced this issue Jul 19, 2021
@feelform
pinpoint-apm#7 Add Node int64 jstype
517aa32
@feelform feelform mentioned this issue Jul 19, 2021
Closed
@feelform feelform linked a pull request Jul 19, 2021 that will close this issue
[#8] Support Pinpoint Node agent long type #9
Closed
feelform added a commit to feelform/pinpoint-grpc-idl that referenced this issue Jul 20, 2021
@feelform
pinpoint-apm#7 add PApiMetaData.location
146713e
@feelform feelform removed a link to a pull request Jul 20, 2021
[#8] Support Pinpoint Node agent long type #9
Closed
@feelform feelform linked a pull request Jul 20, 2021 that will close this issue
[#7] add PApiMetaData.location #10
Merged
@emeroad emeroad changed the title add PApiMetaData.location Add PApiMetaData.location Aug 11, 2021
@emeroad emeroad added this to the 2.3.1 milestone Aug 11, 2021
emeroad pushed a commit that referenced this issue Aug 11, 2021
@feelform @emeroad
#7 add PApiMetaData.location
2b3f8ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging a pull request may close this issue.

[#7] add PApiMetaData.location feelform/pinpoint-grpc-idl
2 participants
@feelform @emeroad