Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add link and unlink #1587

Closed
wants to merge 1 commit into from
Closed

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

cannot run installed component directly

What is changed and how it works?

add command tiup link and tiup unlink

  • tiup link add a soft link to target component in ~/.tiup/bin
  • tiup unlink remove it

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from july2993 and lonng October 18, 2021 03:56
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #1587 (f15d488) into master (5c91cf9) will increase coverage by 34.92%.
The diff coverage is 41.02%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1587       +/-   ##
===========================================
+ Coverage   15.78%   50.71%   +34.92%     
===========================================
  Files         149      292      +143     
  Lines       15023    26398    +11375     
===========================================
+ Hits         2372    13387    +11015     
+ Misses      12133    10996     -1137     
- Partials      518     2015     +1497     
Flag Coverage Δ
cluster 43.85% <ø> (?)
dm 26.19% <ø> (?)
integrate 50.71% <41.02%> (+34.92%) ⬆️
playground 13.53% <ø> (?)
tiup 15.85% <41.02%> (+0.06%) ⬆️
unittest ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/link.go 31.81% <31.81%> (ø)
cmd/unlink.go 46.66% <46.66%> (ø)
cmd/root.go 72.60% <100.00%> (+0.38%) ⬆️
components/cluster/command/test.go 58.66% <0.00%> (ø)
components/dm/command/edit_config.go 80.00% <0.00%> (ø)
components/cluster/command/import.go 19.10% <0.00%> (ø)
components/dm/command/template.go 41.17% <0.00%> (ø)
pkg/cluster/operation/check.go 48.58% <0.00%> (ø)
components/playground/instance/tiflash_config.go 100.00% <0.00%> (ø)
components/dm/spec/logic.go 78.19% <0.00%> (ø)
... and 236 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c91cf9...f15d488. Read the comment docs.

@AstroProfundis AstroProfundis added this to the v1.8.0 milestone Oct 26, 2021
@AstroProfundis AstroProfundis added the component/tiup Issues about the TiUP package management component itself label Oct 26, 2021
@AstroProfundis
Copy link
Contributor

/hold

We'll continue this after v1.7.0 been released.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 26, 2021
@nexustar nexustar closed this Nov 15, 2021
@AstroProfundis AstroProfundis modified the milestones: v1.9.0, Next Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/tiup Issues about the TiUP package management component itself do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants