Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert bef3924c in release 7.1 #9932

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Revert bef3924c in release 7.1 #9932

merged 1 commit into from
Oct 19, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Oct 19, 2023 •
edited by wuhuizuo
Loading

What problem does this PR solve?

Issue Number: ref #9926

What is changed and how it works?

revert #9851

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2023
@CharlesCheung96 CharlesCheung96 changed the base branch from master to release-7.1 October 19, 2023 02:51
@CharlesCheung96
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 19, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 19, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-19 05:04:55.425815453 +0000 UTC m=+1892693.012925595: ☑️ agreed by asddongmen.
  • 2023-10-19 05:38:26.252256259 +0000 UTC m=+1894703.839366399: ☑️ agreed by nongfushanquan.

@nongfushanquan
Copy link
Contributor

/retest

@nongfushanquan
Copy link
Contributor

/check-issue-triage-complete

@nongfushanquan
Copy link
Contributor

/run-check-issue-triage-complete

@Ivy-YinSu
Copy link

/run check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/run-check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

7 similar comments
@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

1 similar comment
@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo wuhuizuo added the skip-issue-check Indicates that a PR no need to check linked issue. label Oct 19, 2023
@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@wuhuizuo wuhuizuo removed skip-issue-check Indicates that a PR no need to check linked issue. do-not-merge/needs-triage-completed labels Oct 19, 2023
@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot merged commit 6ba0aec into pingcap:release-7.1 Oct 19, 2023
@wuhuizuo
Copy link
Contributor

/check-issue-triage-complete

Maybe it is a bug of the triage plugin.

@CharlesCheung96 CharlesCheung96 mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CharlesCheung96 @nongfushanquan @Ivy-YinSu @wuhuizuo @asddongmen @ti-chi-bot