Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeed(ticdc): check changefeed info is nil to prevent panic #9917

Merged
merged 1 commit into from
Oct 18, 2023
Merged

changefeed(ticdc): check changefeed info is nil to prevent panic #9917

merged 1 commit into from
Oct 18, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9915

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

fix panic caused by changefeed info is nil

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2023
@3AceShowHand 3AceShowHand added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 17, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nongfushanquan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 17, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 08:26:14.812757115 +0000 UTC m=+1731972.399867260: ☑️ agreed by sdojjy.
  • 2023-10-17 08:31:55.841405427 +0000 UTC m=+1732313.428515568: ☑️ agreed by nongfushanquan.

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@3AceShowHand
Copy link
Contributor Author

/test verify

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023 •
edited
Loading

@3AceShowHand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test c5288df link true /test dm-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 0a70e3a into pingcap:master Oct 18, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9923.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 18, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9924.

This was referenced Oct 18, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9925.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@ti-chi-bot
changefeed(ticdc): check changefeed info is nil to prevent panic (#9917…
05f70a9 
…) (#9923)

close #9915
ti-chi-bot bot pushed a commit that referenced this pull request Oct 18, 2023
@ti-chi-bot
changefeed(ticdc): check changefeed info is nil to prevent panic (#9917…
a9cc735 
…) (#9924)

close #9915
ti-chi-bot bot pushed a commit that referenced this pull request Nov 8, 2023
@ti-chi-bot
changefeed(ticdc): check changefeed info is nil to prevent panic (#9917…
1ead19f 
…) (#9925)

close #9915
@nongfushanquan nongfushanquan mentioned this pull request Nov 14, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdc panic on the upstream manager
4 participants
@3AceShowHand @ti-chi-bot @sdojjy @nongfushanquan