Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server(ticc): add feature flag for cdc v2 #9914

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Oct 17, 2023

What problem does this PR solve?

Issue Number: close #9913

What is changed and how it works?

add a flag to create new capture implememtation

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Oct 17, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 18, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 07:03:03.544538866 +0000 UTC m=+1813381.131649011: ☑️ agreed by CharlesCheung96.
  • 2023-10-18 09:04:15.519663503 +0000 UTC m=+1820653.106773648: ☑️ agreed by 3AceShowHand.

@sdojjy
Copy link
Member Author

sdojjy commented Oct 18, 2023

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit 230ee2e into pingcap:master Oct 18, 2023
@sdojjy sdojjy deleted the add-feature-flag-for-cdc-v2 branch October 18, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add feature flag for cdc v2
3 participants