Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc(ticdc): fix data race in gc manager #9897

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Oct 16, 2023

What problem does this PR solve?

Issue Number: close #9895

What is changed and how it works?

use atomic bool to fix the data race

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2023
@sdojjy
Copy link
Member Author

sdojjy commented Oct 16, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-16 09:49:45.33265874 +0000 UTC m=+1650582.919768887: ☑️ agreed by nongfushanquan.
  • 2023-10-16 10:03:22.383395615 +0000 UTC m=+1651399.970505761: ☑️ agreed by 3AceShowHand.

@sdojjy
Copy link
Member Author

sdojjy commented Oct 16, 2023

/retest-required

1 similar comment
@sdojjy
Copy link
Member Author

sdojjy commented Oct 17, 2023

/retest-required

@sdojjy
Copy link
Member Author

sdojjy commented Oct 17, 2023

/test cdc-integration-storage-test
/test dm-integration-test

@sdojjy
Copy link
Member Author

sdojjy commented Oct 17, 2023

/test cdc-integration-storage-test

@ti-chi-bot ti-chi-bot bot merged commit 3b3b61e into pingcap:master Oct 17, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9908.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 17, 2023
@sdojjy sdojjy deleted the fix-data-race-for-in-gc-manager branch October 17, 2023 02:56
@sdojjy sdojjy added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Oct 17, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9909.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data race found in the gc manager TryUpdateGCSafePoint
4 participants