Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm: fix lag keeps growing when failed ddl is skipped and no following ddl (#9607) #9614

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9607

What problem does this PR solve?

Issue Number: close #9605

What is changed and how it works?

  • reset recorded ts on syncer restart

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • test using steps in the issue, before the change, lag keeps growing, became 0 after this pr
before 

➜  dm curl -s "127.0.0.1:8361/metrics" | grep -v '#'| grep dm_syncer_replication_lag_gauge
dm_syncer_replication_lag_gauge{source_id="mysql-3307",task="test",worker="worker-1"} 303
➜  dm curl -s "127.0.0.1:8361/metrics" | grep -v '#'| grep dm_syncer_replication_lag_gauge
dm_syncer_replication_lag_gauge{source_id="mysql-3307",task="test",worker="worker-1"} 313


after
➜  dm curl -s "127.0.0.1:8361/metrics" | grep -v '#'| grep dm_syncer_replication_lag_gauge
dm_syncer_replication_lag_gauge{source_id="mysql-3307",task="test",worker="worker-1"} 0
➜  dm curl -s "127.0.0.1:8361/metrics" | grep -v '#'| grep dm_syncer_replication_lag_gauge
dm_syncer_replication_lag_gauge{source_id="mysql-3307",task="test",worker="worker-1"} 0
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

fix lag keeps growing when failed ddl is skipped and no following ddl

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2023
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 21, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. label Aug 21, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2023
@D3Hunter
Copy link
Contributor

D3Hunter commented Oct 7, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit a3c2273 into pingcap:release-7.1 Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants