Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysql(ticdc): consider collation when build the causality key #9534

Merged
merged 6 commits into from
Aug 10, 2023
Merged

mysql(ticdc): consider collation when build the causality key #9534

merged 6 commits into from
Aug 10, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9533

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2023
@3AceShowHand
Copy link
Contributor Author

/run-check-issue-triage-complete

@lance6716
Copy link
Contributor

can we use sqlmodel library? In future we will implement more features

@3AceShowHand
Copy link
Contributor Author

can we use sqlmodel library? In future we will implement more features

It's better if TiCDC and DM can share the same library.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,hicqu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 10, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-10 04:28:56.608548751 +0000 UTC m=+173301.157564723: ☑️ agreed by hicqu.
  • 2023-08-10 05:03:22.222644731 +0000 UTC m=+175366.771660717: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 10, 2023
@3AceShowHand 3AceShowHand requested a review from hicqu August 10, 2023 08:04
@3AceShowHand
Copy link
Contributor Author

/test verify

@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit e04b346 into pingcap:master Aug 10, 2023
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-6.5

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-6.5: #9556.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 13, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Aug 13, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9534
931972b 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-7.1: #9557.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 13, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Aug 15, 2023
@ti-chi-bot
mysql(ticdc): consider collation when build the causality key (#9534) (…
a86be64 
…#9556)

close #9533
ti-chi-bot bot pushed a commit that referenced this pull request Aug 16, 2023
@ti-chi-bot
mysql(ticdc): consider collation when build the causality key (#9534) (…
9e456e2 
…#9557)

close #9533
3AceShowHand added a commit to 3AceShowHand/tiflow that referenced this pull request Aug 29, 2023
@3AceShowHand
mysql(ticdc): consider collation when build the causality key (pingca…
ac1c85b 
…p#9534)

close pingcap#9533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy Awaiting requested review from sdojjy

@asddongmen asddongmen Awaiting requested review from asddongmen

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

@CharlesCheung96 CharlesCheung96 Awaiting requested review from CharlesCheung96

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ticdc causality should be case sensitive
5 participants
@3AceShowHand @lance6716 @ti-chi-bot @hicqu @CharlesCheung96