Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puller(ticdc): fix renameTables ddl job #9471

Merged
merged 2 commits into from
Aug 3, 2023
Merged

puller(ticdc): fix renameTables ddl job #9471

merged 2 commits into from
Aug 3, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Aug 1, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9476

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 1, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 1, 2023
@CharlesCheung96
Copy link
Contributor Author

/test all

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96
Copy link
Contributor Author

/retest

@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review August 2, 2023 02:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 3, 2023
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Aug 3, 2023
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, nongfushanquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-03 03:34:57.390539501 +0000 UTC m=+329181.332888032: ☑️ agreed by asddongmen.
  • 2023-08-03 06:39:07.87436576 +0000 UTC m=+340231.816714292: ☑️ agreed by nongfushanquan.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 6ac0e46 into pingcap:master Aug 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9491.

This was referenced Aug 3, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9493.

@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-7.3 Should cherry pick this PR to release-7.3 branch. label Aug 3, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #9495.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 3, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Aug 4, 2023
@ti-chi-bot
puller(ticdc): fix renameTables ddl job (#9471) (#9495)
51fb570 
close #9476
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2023
@ti-chi-bot
puller(ticdc): fix renameTables ddl job (#9471) (#9493)
4050648 
close #9476
ti-chi-bot bot pushed a commit that referenced this pull request Aug 22, 2023
@ti-chi-bot
puller(ticdc): fix renameTables ddl job (#9471) (#9491)
f7556c8 
close #9476
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Aug 29, 2023
@CharlesCheung96 @3AceShowHand
puller(ticdc): fix renameTables ddl job (pingcap#9471)
85a8bf9 
close pingcap#9476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 Should cherry pick this PR to release-7.3 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CDC:ErrSnapshotSchemaNotFound] schema 41766 not found in schema snapshot
4 participants
@CharlesCheung96 @ti-chi-bot @asddongmen @nongfushanquan