Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chngefeed (ticdc): move resolvedTs into globalBarrierTs when redo log is enabled. #9138

Merged
merged 12 commits into from
Jun 12, 2023
Merged

chngefeed (ticdc): move resolvedTs into globalBarrierTs when redo log is enabled. #9138

merged 12 commits into from
Jun 12, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Jun 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #9058

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot requested a review from D3Hunter June 6, 2023 09:03
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot requested a review from iamxy June 6, 2023 09:03
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 6, 2023
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 8, 2023
@asddongmen
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2023
@asddongmen
Copy link
Contributor Author

/test cdc-integration-mysql-test

@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@asddongmen
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@asddongmen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify

In response to this:

/test cdc-integration-mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen
Copy link
Contributor Author

/test cdc-integration-mysql-test

@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 9, 2023

@asddongmen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify

In response to this:

/test cdc-integration-kafka-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@asddongmen
Copy link
Contributor Author

/test cdc-integration-kafka-test

@asddongmen
Copy link
Contributor Author

/test all

@asddongmen asddongmen added the status/ptal Could you please take a look? label Jun 9, 2023
@asddongmen asddongmen requested review from sdojjy, charleszheng44, 3AceShowHand and CharlesCheung96 and removed request for D3Hunter and iamxy June 9, 2023 08:50
@asddongmen asddongmen mentioned this pull request Jun 9, 2023
Closed
6 tasks
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 9, 2023
sdojjy
sdojjy reviewed Jun 12, 2023
View reviewed changes
cdc/processor/processor.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-09 09:25:47.632356256 +0000 UTC m=+76761.880278079: ☑️ agreed by 3AceShowHand.
  • 2023-06-12 03:22:39.786320371 +0000 UTC m=+122709.241081673: ☑️ agreed by sdojjy.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit dbe5cc1 into pingcap:master Jun 12, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #9178.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 12, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#9138
1b30f31 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 12, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #9179.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jun 12, 2023
@asddongmen @ti-chi-bot
This is an automated cherry-pick of pingcap#9138
03e43dc 
Signed-off-by: ti-chi-bot <[email protected]>
@asddongmen asddongmen mentioned this pull request Jul 3, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Jul 4, 2023
@asddongmen
changefeed (ticdc):Manual cherry pick #9138, #9194 to release 7.1 (#9326
a3cdfdb 
)

ref #9058, ref #9235
ti-chi-bot bot pushed a commit that referenced this pull request Aug 8, 2023
@ti-chi-bot
chngefeed (ticdc): move resolvedTs into globalBarrierTs when redo log…
dcf789a 
… is enabled. (#9138) (#9178)

ref #9058
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@charleszheng44 charleszheng44 Awaiting requested review from charleszheng44

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asddongmen @ti-chi-bot @sdojjy @3AceShowHand @CharlesCheung96