config(dm): limit the length of hostname in binlog replication to 60 #8465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lance6716 <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
do-not-merge/needs-linked-issue
release-note
okJiang
approved these changes
Mar 9, 2023
maxshuang
approved these changes
Mar 9, 2023
ti-chi-bot
added
status/LGT2
D3Hunter
approved these changes
Mar 9, 2023
maxshuang
reviewed
Mar 9, 2023
| h, _ := os.Hostname() | ||
| h = "dm-relay-" + h | ||
| // https://github.com/mysql/mysql-server/blob/1bfe02bdad6604d54913c62614bde57a055c8332/include/my_hostname.h#L33-L42 | ||
| if len(h) > 60 { |
There was a problem hiding this comment.
Maybe put it in a string util is better.
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: dc004c1
|
ti-chi-bot
added
the
status/can-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #4287
What is changed and how it works?
fix sync unit of DM-worker can't run on a machine that has long hostname
Check List
Tests
https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftiflow%2Fpull_dm_compatibility_test/detail/pull_dm_compatibility_test/14/pipeline/
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note